Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Message count is not changing after removing channel selection #30799

Closed
wants to merge 14 commits into from
Closed

fix: Message count is not changing after removing channel selection #30799

wants to merge 14 commits into from

Conversation

felipe-rod123
Copy link
Contributor

@felipe-rod123 felipe-rod123 commented Oct 29, 2023 •
edited
Loading

Proposed changes (including videos or screenshots)

  • Created a new hook to filter messages with the corresponding userId or roomId from the channel.
  • Created a new messages prop on the IImportFileData.ts: messages: Array<Pick<IImportMessage, '_id' | 'rid' | 'u'>>;

Issue(s)

WM-123

Steps to test or reproduce

Steps to reproduce:

  1. Open RC
  2. Click on “Workspace” → Import
  3. Click on “Import new file”
  4. Select the import optione.g: Slack
  5. Upload the file
  6. In the table, remove some channels from the selection

Expected Behavior:
The number of messages should change after removing some channels (with messages) from the selection

Actual Behavior:
The number is fixed

image

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 99bec23

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ddp-client Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Oct 29, 2023 •
edited
Loading

Codecov Report

Merging #30799 (99bec23) into develop (fb33b91) will increase coverage by 1.06%.
The diff coverage is 87.50%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30799      +/-   ##
===========================================
+ Coverage    56.72%   57.79%   +1.06%     
===========================================
  Files          883     1753     +870     
  Lines        19990    33631   +13641     
  Branches      3689     6878    +3189     
===========================================
+ Hits         11340    19436    +8096     
- Misses        7956    12682    +4726     
- Partials       694     1513     +819
Flag Coverage Δ
e2e 50.99% <87.50%> (+8.59%) ⬆️
unit 75.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@felipe-rod123 felipe-rod123 marked this pull request as ready for review November 13, 2023 13:34
@felipe-rod123 felipe-rod123 requested review from a team as code owners November 13, 2023 13:34
@felipe-rod123 felipe-rod123 requested a review from ggazzo November 17, 2023 14:04
@felipe-rod123 felipe-rod123 mentioned this pull request Nov 17, 2023
Closed
tapiarafael
tapiarafael previously approved these changes Nov 20, 2023
View reviewed changes
hugocostadev
hugocostadev suggested changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@hugocostadev hugocostadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reactivity in the front end is broken, after removing Channels/Users selection the message count it still not updating and navigating with the tabs the channel/ users selection resets with the initial value.

apps/meteor/client/views/admin/import/PrepareImportPage.js Show resolved Hide resolved
.changeset/importer-messages-count.md Show resolved Hide resolved
apps/meteor/client/views/admin/import/NewImportPage.js Show resolved Hide resolved
@hugocostadev hugocostadev changed the title chore: Message count is not changing after removing channel selection fix: Message count is not changing after removing channel selection Dec 1, 2023
@felipe-rod123 felipe-rod123 mentioned this pull request Dec 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugocostadev hugocostadev hugocostadev requested changes

@ggazzo ggazzo Awaiting requested review from ggazzo

@tapiarafael tapiarafael Awaiting requested review from tapiarafael

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@felipe-rod123 @ggazzo @tapiarafael @hugocostadev